Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load_state parameter type err #1768

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: load_state parameter type err #1768

merged 1 commit into from
Nov 3, 2023

Conversation

simonwei97
Copy link
Contributor

fix issue #1764

load_state parameter partition_names error

@sre-ci-robot
Copy link

Welcome @simonwei97! It looks like this is your first PR to milvus-io/pymilvus 🎉

@mergify mergify bot added the needs-dco label Nov 1, 2023
@XuanYang-cn
Copy link
Contributor

@simonwei97 Good catch! Could you please follow the instruction of DCO robot to sign this pr https://github.com/milvus-io/pymilvus/pull/1768/checks?check_run_id=18249075968

I'll merge this PR if DCO robot check pass

@simonwei97
Copy link
Contributor Author

@simonwei97 Good catch! Could you please follow the instruction of DCO robot to sign this pr https://github.com/milvus-io/pymilvus/pull/1768/checks?check_run_id=18249075968

I'll merge this PR if DCO robot check pass

OK, I will do this.

@simonwei97 simonwei97 force-pushed the fix/load_state-param-err branch from 7e51291 to 49f9288 Compare November 1, 2023 14:16
@mergify mergify bot added dco-passed and removed needs-dco labels Nov 1, 2023
@simonwei97
Copy link
Contributor Author

DCO has been check passed

@simonwei97
Copy link
Contributor Author

/assign @XuanYang-cn

@mergify mergify bot added the ci-passed label Nov 2, 2023
@simonwei97 simonwei97 force-pushed the fix/load_state-param-err branch from 49f9288 to 39a87b1 Compare November 3, 2023 01:49
@simonwei97
Copy link
Contributor Author

@XuanYang-cn Please review. Thanks.

@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonwei97, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 59c6f0c into milvus-io:master Nov 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangting0128 wangting0128 Awaiting requested review from wangting0128

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@XuanYang-cn XuanYang-cn

Labels
approved ci-passed dco-passed lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonwei97 @sre-ci-robot @XuanYang-cn